Skip to content

Expose base class in settings doc #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2023
Merged

Expose base class in settings doc #1632

merged 1 commit into from
May 24, 2023

Conversation

@hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented May 24, 2023 •
edited
Loading

Exposed base class in settings doc.

image

@hpohekar hpohekar linked an issue May 24, 2023 that may be closed by this pull request
base class information gone from **Settings** API documentation #1630
Closed
@hpohekar hpohekar mentioned this pull request May 24, 2023
Closed
@seanpearsonuk
Copy link
Collaborator

I'm noticing a pre-existing issue regarding broken links in the dev docs which makes it difficult to check the results of these changes. @hpohekar

@hpohekar
Copy link
Collaborator Author

hpohekar commented May 24, 2023 •
edited
Loading

I'm noticing a pre-existing issue regarding broken links in the dev docs which makes it difficult to check the results of these changes. @hpohekar

@seanpearsonuk This change will be effective after running nightly doc build. In description I have pasted screenshot of local doc build. Can you please mention the broken links ? The linked issue does not describe any information related to broken links. Thanks.

@seanpearsonuk
Copy link
Collaborator

I'm noticing a pre-existing issue regarding broken links in the dev docs which makes it difficult to check the results of these changes. @hpohekar

@seanpearsonuk This change will be effective after running nightly doc build. In description I have pasted screenshot of local doc build. Can you please mention the broken links ? The linked issue does not describe any information related to broken links. Thanks.

@hpohekar
Thanks for pasting the image.
You'll see a lot of things not clickable in api/solver/settings.html and api/solver/index.html.

@seanpearsonuk
Copy link
Collaborator

@hpohekar I can add another separate issue about the dev doc build, but please ignore it.

@hpohekar hpohekar merged commit 29246b6 into main May 24, 2023
@hpohekar hpohekar deleted the doc/fix_base_class branch May 24, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@prmukherj prmukherj prmukherj approved these changes

@mkundu1 mkundu1 Awaiting requested review from mkundu1 mkundu1 is a code owner

@ajain-work ajain-work Awaiting requested review from ajain-work

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work

@h-krishnan h-krishnan Awaiting requested review from h-krishnan

@raph-luc raph-luc Awaiting requested review from raph-luc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

base class information gone from **Settings** API documentation

3 participants

@hpohekar @seanpearsonuk @prmukherj