Remote launcher: don't provide any product version by default #1639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plule-ansys
requested review from
ajain-work,
dnwillia-work,
h-krishnan,
hpohekar,
mkundu1,
prmukherj,
raph-luc and
seanpearsonuk
as code owners
mkundu1
approved these changes
May 25, 2023
hpohekar
approved these changes
May 25, 2023
|
edit: was just a random test failure, on re-run without any changes it now passed |
raph-luc
approved these changes
May 25, 2023
seanpearsonuk
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1604 for the fix for #1591 This is just a small adjustment, I was out so I missed the review, but thank you for the quick fix @prmukherj
When the user does not explicitly request for a version, then
Noneshould be used.latestis not a standard name for a version so it will likely not be available. LeavingNonewill let the backend choose. I will add a note on this in thepypimdocumentation, at the moment it's only explain in the.protoI believe.