Skip to content

Package all .pyi files #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2023
Merged

Package all .pyi files #1640

merged 1 commit into from
May 25, 2023

Conversation

@mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented May 25, 2023

No description provided.

@raph-luc
Copy link
Member

raph-luc commented May 25, 2023 •
edited
Loading

Good stuff, this with #1638 solves all the issues related to #1609

Managed to reproduce the issues on VSCode Intellisense, and this fixes them:
image

Can confirm it works on PyCharm too

@raph-luc
Copy link
Member

tests/test_streaming_services.py::test_transcript had randomly failed again, on re-run without any other changes it passed, but now tests/test_session.py::test_journal_creation has failed for no apparent reason, looking into this

@raph-luc
Copy link
Member

After re-runs passed all tests, merging

@raph-luc raph-luc merged commit c9387be into main May 25, 2023
@raph-luc raph-luc deleted the fix/packaging branch May 25, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@hpohekar hpohekar hpohekar approved these changes

@raph-luc raph-luc raph-luc approved these changes

@ajain-work ajain-work Awaiting requested review from ajain-work

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work

@prmukherj prmukherj Awaiting requested review from prmukherj prmukherj is a code owner

@h-krishnan h-krishnan Awaiting requested review from h-krishnan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mkundu1 @raph-luc @seanpearsonuk @hpohekar