Attempt to fix tests that are randomly failing #1641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raph-luc
changed the title
raph-luc
requested review from
ajain-work,
dnwillia-work,
h-krishnan,
hpohekar,
mkundu1,
prmukherj and
seanpearsonuk
as code owners
mkundu1
approved these changes
May 25, 2023
hpohekar
approved these changes
May 26, 2023
prmukherj
approved these changes
May 26, 2023
seanpearsonuk
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/test_streaming_services.py::test_transcripthas been randomly failing on github test runners, likely due to it being a server-side stress test, and this has been blocking PRsExamples where it first failed, then passed on re-run without any changes:
https://github.com/ansys/pyfluent/actions/runs/5082325343/jobs/9131963505?pr=1640
https://github.com/ansys/pyfluent/actions/runs/5082183987/jobs/9131631586?pr=1639
https://github.com/ansys/pyfluent/actions/runs/5016027626/jobs/8992408253
As @mkundu1 suggested, one possible way to deal with this is to use a better runner, and that is what this PR is doing by changing it to a self-hosted pyfluent runner
If it continues randomly failing we will have to rework this test
CC: @prmukherj
update:
tests/test_session.py::test_journal_creationhas been failing for no reason too (e.g. https://github.com/ansys/pyfluent/actions/runs/5082325343/jobs/9132695993 and https://github.com/ansys/pyfluent/actions/runs/5082965763/jobs/9133417557?pr=1641), we can use this PR for that one as welladding small delays between actions in the
tests/test_session.py::test_journal_creation, to give the file system some time to work through the changes