Skip to content

Set container mount path from env var #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2023
Merged

Set container mount path from env var #1659

merged 2 commits into from
Jun 2, 2023

Conversation

@mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Jun 2, 2023 •
edited
Loading

This is useful while launching the Fluent docker container from PyFluent in Windows host for development purpose. We cannot mount a Windows path within the Linux container.

raph-luc
raph-luc approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@raph-luc raph-luc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea and good change, removed some comments that are now outdated and not necessary anymore

@mkundu1
Copy link
Contributor Author

mkundu1 commented Jun 2, 2023

Good idea and good change, removed some comments that are now outdated and not necessary anymore

Thanks

@mkundu1 mkundu1 merged commit 28b55c7 into main Jun 2, 2023
@mkundu1 mkundu1 deleted the fix/container-mount-path branch June 2, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hpohekar hpohekar hpohekar approved these changes

@raph-luc raph-luc raph-luc approved these changes

@seanpearsonuk seanpearsonuk Awaiting requested review from seanpearsonuk seanpearsonuk is a code owner

@ajain-work ajain-work Awaiting requested review from ajain-work

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work

@prmukherj prmukherj Awaiting requested review from prmukherj prmukherj is a code owner

@h-krishnan h-krishnan Awaiting requested review from h-krishnan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkundu1 @hpohekar @raph-luc