Skip to content

Conversation

@raph-luc
Copy link
Member

@raph-luc raph-luc commented Jul 6, 2023

Adding exception catch to Watchdog module that writes to a pyfluent_watchdog.err file if it catches anything, and additional logging calls

Edit: regardless of diagnosing the user issue, I think these changes should be merged into main, as they may be helpful in the future, going to mark this PR ready for review.

The changes to watchdog.py file are hard to understand on GitHub, but are mainly just tabbing everything to the right to add a try except block to log any exceptions:

except Exception as exc:
with open("pyfluent_watchdog.err", "a") as file:
file.write("%s: %s" % (type(exc).__name__, exc))

@raph-luc raph-luc marked this pull request as ready for review July 7, 2023 17:43
@raph-luc raph-luc changed the title Helping user diagnose issue Minor watchdog improvements (helping user diagnose issue) Jul 7, 2023
@raph-luc raph-luc merged commit 083d5b0 into main Jul 10, 2023
@raph-luc raph-luc deleted the fix/watchdog_improvements branch July 10, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants