Enable parametric test for 24.1 #1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
force-pushed
the
testing/parametric-241
branch
2 times, most recently
from
a6162d8 to
2c63f68
Compare
mkundu1
requested review from
ajain-work,
dnwillia-work,
h-krishnan,
hpohekar,
prmukherj,
raph-luc and
seanpearsonuk
as code owners
hpohekar
approved these changes
Jul 15, 2023
prmukherj
approved these changes
Jul 17, 2023
seanpearsonuk
approved these changes
Jul 17, 2023
mkundu1
force-pushed
the
testing/parametric-241
branch
from
d8bb258 to
88f7b1f
Compare
raph-luc
reviewed
Jul 17, 2023
raph-luc
reviewed
Jul 17, 2023
raph-luc
changed the title
raph-luc
reviewed
Jul 17, 2023
raph-luc
approved these changes
Jul 17, 2023
Member
There was a problem hiding this comment.
This works for Linux host with Linux container guest, my suggestions (see the PR linked above) are thinking about making this more general and OS-independent as well as potentially container vs standalone vs remote independent. Not sure on the feasibility of doing this, however, so those are just suggestions for consideration/food for thought (I still need some time to work on and test them too).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test run result - https://github.com/ansys/pyfluent/actions/runs/5559483041