Skip to content

Conversation

@mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Jul 27, 2023

@seanpearsonuk seanpearsonuk changed the title Move some settigns API tests to 23.2 or later as they reflect the latest usage Move some settings API tests to 23.2 or later as they reflect the latest usage Jul 27, 2023
@seanpearsonuk
Copy link
Collaborator

seanpearsonuk commented Jul 27, 2023

FOR SEPARATE CONSIDERATION For a directory like test_solvermode, where we are purely exercising a Fluent API, the testing of released Fluent versions can be considered complete, and anyway any issues cannot be resolved any more. Therefore, I would propose that this directory is only applicable to the latest version - the current unreleased version under development. If we can associate a whole directory with a release version without additional need for marking individual tests, that would be ideal. Other tests, that aren't purely concerned with API testing should try to minimise and simplify their API use and try to use stable parts of APIs.

@mkundu1
Copy link
Contributor Author

mkundu1 commented Jul 27, 2023

FOR SEPARATE CONSIDERATION For a directory like test_solvermode, where we are purely exercising a Fluent API, the testing of released Fluent versions can be considered complete, and anyway any issues cannot be resolved any more. Therefore, I would propose that this directory is only applicable to the latest version - the current unreleased version under development. If we can associate a whole directory with a release version without additional need for marking individual tests, that would be ideal. Other tests, that aren't purely concerned with API testing should try to minimise and simplify their API use and try to use stable parts of APIs.

Agree, these tests should test the Fluent API under development as that is the only thing which may fail these tests. We already have documentation examples and pyfluent-examples repo to demonstrate Fluent API usage of the released Fluent version. I'll mark these tests with 24.1 which will also reduce the test running time.

@seanpearsonuk
Copy link
Collaborator

FOR SEPARATE CONSIDERATION For a directory like test_solvermode, where we are purely exercising a Fluent API, the testing of released Fluent versions can be considered complete, and anyway any issues cannot be resolved any more. Therefore, I would propose that this directory is only applicable to the latest version - the current unreleased version under development. If we can associate a whole directory with a release version without additional need for marking individual tests, that would be ideal. Other tests, that aren't purely concerned with API testing should try to minimise and simplify their API use and try to use stable parts of APIs.

Agree, these tests should test the Fluent API under development as that is the only thing which may fail these tests. We already have documentation examples and pyfluent-examples repo to demonstrate Fluent API usage of the released Fluent version. I'll mark these tests with 24.1 which will also reduce the test running time.

Thanks a lot @mkundu1.

@cj-hodgson @millerj97 letting you know what we're up to here

@mkundu1 mkundu1 changed the title Move some settings API tests to 23.2 or later as they reflect the latest usage Move the Fluent API tests to run with 24.1 Fluent version Jul 27, 2023
@mkundu1 mkundu1 requested review from cj-hodgson and millerj97 July 27, 2023 17:01
@mkundu1 mkundu1 merged commit 470ed7f into main Jul 28, 2023
@mkundu1 mkundu1 deleted the fix/nightly-231 branch July 28, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants