Removal of the units quantity package #1999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansaboutin
requested review from
ajain-work,
dnwillia-work,
h-krishnan,
hpohekar,
prmukherj,
raph-luc and
seanpearsonuk
as code owners
hpohekar
approved these changes
Sep 21, 2023
prmukherj
approved these changes
Sep 21, 2023
raph-luc
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
There is another mention in the documentation, that I believe should also be removed, to the units quantity package:
pyfluent/doc/source/api/index.rst
Line 17 in 175b514
…om/ansys/pyfluent into fix/removal_units_quantity_package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package can now be found here: https://github.com/ansys/pyansys-units
Removed the
ansys.fluent.core.quantitypackage.Removed the tests at
tests/test_unitsRemoved the documentation at
doc/source/api/general/quantity.rstRemoved the reference in
doc/source/api/general/index.rst