Skip to content

Conversation

@ansjsia
Copy link
Collaborator

@ansjsia ansjsia commented Nov 6, 2023

Upgrades:

  • TUI calls replaced with Settings API calls where possible (except for Exhaust System example, where a new example using the Settings API has been created to avoid overwriting the TUI example)
  • Tested with Fluent 24R1
  • Tested with PyFluent 0.18.1

This should be merged only once the switchover to 24R1 is complete.

@raph-luc
Copy link
Member

raph-luc commented Nov 9, 2023

Converting this to a draft: to be reopened after 24.1 is released and the repo is updated to support it

@ansjsia
Copy link
Collaborator Author

ansjsia commented Dec 6, 2023

The last commit to change .msh to .msh.gz in the cavitation example is dependent on changes made in this PR: ansys/example-data#214

@ansjsia ansjsia added the documentation Documentation related (improving, adding, etc) label Dec 11, 2023
@ansjsia
Copy link
Collaborator Author

ansjsia commented Dec 19, 2023

The CI/CD pipeline is throwing RuntimeError: menu not found on line 629 of exhaust_system.py, when it makes the call solver.tui.display.set.picture.use_window_resolution("no"). I can't replicate this problem locally nor directly in the TUI. Any insights on why this might be happening? @dnwillia-work @raph-luc

EDIT: This was found to be an issue with containers. The solution is to not call that command if Fluent is running in a container.

@mkundu1
Copy link
Contributor

mkundu1 commented Jan 15, 2024

@ansjsia This can be merged after #2349 which updates fluent_release_version.

We need to update the Fluent version in the .yml files for documentation CI.

cc: @prmukherj

@mkundu1 mkundu1 force-pushed the doc/examples-upgrade-24.1 branch from ef8291a to d431127 Compare January 16, 2024 03:35
@mkundu1 mkundu1 changed the title Upgrade examples to 24.1 and PyFluent 0.18.1 Upgrade examples to 24.1 Jan 16, 2024
@hpohekar hpohekar changed the title Upgrade examples to 24.1 refactor: Upgrade examples to 24.1 Jan 16, 2024
@mkundu1 mkundu1 marked this pull request as ready for review January 16, 2024 04:44
@mkundu1 mkundu1 merged commit ea6c3bd into main Jan 16, 2024
@mkundu1 mkundu1 deleted the doc/examples-upgrade-24.1 branch January 16, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation related (improving, adding, etc)

Projects

None yet

7 participants