Skip to content

refactor: Make flobject consistent with server. #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2024
Merged

refactor: Make flobject consistent with server. #2362

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82a70b3
Make flobject consistent with server.
prmukherj Jan 17, 2024
08e5457
Update docstring.
prmukherj Jan 17, 2024
5bcc411
Update src/ansys/fluent/core/solver/flobject.py
prmukherj Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/ansys/fluent/core/solver/flobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@


class InactiveObjectError(RuntimeError):
"""Provides the error when the object is inactive."""
"""Inactive object access."""

def __init__(self):
super().__init__("Object is not active.")
def __init__(self, python_path):
super().__init__(f"'{python_path}' is currently inactive.")


class _InlineConstants:
Expand Down Expand Up @@ -216,7 +216,7 @@ def get_attr(
if attrs:
attrs = attrs.get("attrs", attrs)
if attr != "active?" and attrs and attrs.get("active?", True) is False:
raise InactiveObjectError()
raise InactiveObjectError(self.python_path)
val = None
if attrs:
val = attrs[attr]
Expand Down Expand Up @@ -581,7 +581,7 @@ def _get_parent_of_active_child_names(self, name):
def __getattribute__(self, name):
if name in super().__getattribute__("child_names"):
if self.is_active() is False:
raise RuntimeError(f"'{self.python_path}' is currently not active")
raise InactiveObjectError(self.python_path)
try:
return super().__getattribute__(name)
except AttributeError as ex:
Expand Down