Skip to content

refactor: svar refactoring #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024
Merged

refactor: svar refactoring #2364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/ansys/fluent/core/services/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from ansys.fluent.core.services.monitor import MonitorsService
from ansys.fluent.core.services.scheme_eval import SchemeEval
from ansys.fluent.core.services.settings import SettingsService
from ansys.fluent.core.services.svar import SVARData, SVARService

_service_cls_by_name = {
"datamodel": DatamodelService_SE,
Expand All @@ -17,6 +18,8 @@
"field_data": FieldData,
"field_info": FieldInfo,
"monitors": MonitorsService,
"svar": SVARService,
"svar_data": SVARData,
}


Expand Down
9 changes: 6 additions & 3 deletions src/ansys/fluent/core/session_solver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@
import threading
from typing import Any, Optional

from ansys.fluent.core.services import service_creator
from ansys.fluent.core.services.datamodel_se import PyMenuGeneric
from ansys.fluent.core.services.datamodel_tui import TUIMenu
from ansys.fluent.core.services.reduction import Reduction, ReductionService
from ansys.fluent.core.services.svar import SVARData, SVARInfo, SVARService
from ansys.fluent.core.services.svar import SVARData, SVARInfo
from ansys.fluent.core.session import _CODEGEN_MSG_TUI, BaseSession, _get_preferences
from ansys.fluent.core.session_shared import _CODEGEN_MSG_DATAMODEL
from ansys.fluent.core.solver import flobject
Expand Down Expand Up @@ -95,7 +96,9 @@ def _build_from_fluent_connection(self, fluent_connection):
self._settings_root = None
self._version = None
self._lck = threading.Lock()
self.svar_service = self.fluent_connection.create_grpc_service(SVARService)
self.svar_service = service_creator("svar").create(
fluent_connection._channel, fluent_connection._metadata
)
self.svar_info = SVARInfo(self.svar_service)
self._reduction_service = self.fluent_connection.create_grpc_service(
ReductionService, self.error_state
Expand All @@ -113,7 +116,7 @@ def build_from_fluent_connection(self, fluent_connection):
@property
def svar_data(self) -> SVARData:
"""Return the SVARData handle."""
return SVARData(self.svar_service, self.svar_info)
return service_creator("svar_data").create(self.svar_service, self.svar_info)

@property
def version(self):
Expand Down