refactor: Make flobject consistent wrt server. #2383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prmukherj
requested review from
ajain-work,
dnwillia-work,
h-krishnan,
hpohekar,
mkundu1,
raph-luc and
seanpearsonuk
as code owners
prmukherj
commented
Jan 23, 2024
prmukherj
commented
Jan 23, 2024
mkundu1
approved these changes
Jan 23, 2024
hpohekar
approved these changes
Jan 23, 2024
2 tasks
gyeole
approved these changes
Jan 29, 2024
prmukherj
commented
Jan 29, 2024
prmukherj
commented
Jan 29, 2024
V-Dandekar
approved these changes
Jan 29, 2024
|
@prmukherj please also bring the Fluent file imediately up to date. There seem to be quite a lot of diffs. Thanks. |
|
@seanpearsonuk, I'll update the fluent side along with this only. |
seanpearsonuk
approved these changes
Jan 30, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2383 +/- ##
==========================================
- Coverage 83.07% 82.90% -0.18%
==========================================
Files 75 75
Lines 8634 8665 +31
==========================================
+ Hits 7173 7184 +11
- Misses 1461 1481 +20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note:
Along with this there should be a couple of minor style fixes in the server side to have the 2 files completely in sync.
There has been some changes in the rename method to support backwards compatibility.
Tests have been added to check the earlier and latest behavior of 'rename' method. Server-side flobject.py will be updated accordingly.