Skip to content

refactor: Make version method private #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 7, 2024
Merged

refactor: Make version method private #2421

merged 9 commits into from
Feb 7, 2024

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Feb 6, 2024 •
edited
Loading

version is specifically used for codegen. We have renamed it to _version so that it is private now.

@hpohekar hpohekar linked an issue Feb 6, 2024 that may be closed by this pull request
Two public ways to get session's Fluent version #2406
Closed
@mkundu1
Copy link
Contributor

mkundu1 commented Feb 6, 2024 •
edited
Loading

Some additional internal cleanups which can be considered (can be done in a separate PR)

  1. Store a FluentVersion object in connection_properties of FluentConnection and pass that around the services (may require some PyConsole adjustment).
  2. I think get_version_for_file_name is just FluentVersion.number.

@hpohekar hpohekar merged commit 6b57fe2 into main Feb 7, 2024
@hpohekar hpohekar deleted the fix/make_solver_version_private branch February 7, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@mkundu1 mkundu1 mkundu1 approved these changes

@prmukherj prmukherj prmukherj approved these changes

@ajain-work ajain-work Awaiting requested review from ajain-work

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work

@h-krishnan h-krishnan Awaiting requested review from h-krishnan

@raph-luc raph-luc Awaiting requested review from raph-luc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Two public ways to get session's Fluent version

4 participants

@hpohekar @mkundu1 @seanpearsonuk @prmukherj