refactor: Rename svar to solution_variables #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

hpohekar merged 25 commits into main from fix/rename_svar

Feb 12, 2024

Collaborator

hpohekar commented Feb 7, 2024 •

edited

Loading

Rename following abbreviations and keep old public names with deprecated warning.

SVARData -> SolutionVariableData
SVARInfo -> SolutionVariableInfo
SVARService -> SolutionVariableService
svar -> solution_variables
svar_data -> solution_variable_data


          refactor: Rename svar to solution_variables

acc4b8b

hpohekar requested review from ajain-work, dnwillia-work, h-krishnan, mkundu1, prmukherj, raph-luc and seanpearsonuk as code owners

February 7, 2024 12:13

hpohekar marked this pull request as draft

February 7, 2024 12:13

hpohekar linked an issue

that may be closed by this pull request

Rename svar to be broadly understood #2403

Closed

hpohekar mentioned this pull request

docs: Rename svar #2405

Closed

hpohekar and others added 10 commits

February 7, 2024 17:46


          Merge branch 'main' into fix/rename_svar

54a083a


          rename public data

d4aa14f


          Merge branch 'fix/rename_svar' of https://github.com/ansys/pyfluent i…

2c9eb00

…nto fix/rename_svar


          rename public data 1

fd67075


          vale fix

f54dbde


          vale fix 1

6159e53


          svar fix

d96a261


          svar fix 1

d71c827


          title fix

3524f7c


          rename version-info -> git_version

d768f62

hpohekar linked an issue

that may be closed by this pull request

version_info() -> git_version()/build_id() #2408

Closed


          solver and test update

4451c3f

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/session_solver.py Outdated Show resolved Hide resolved


          solver and test update 1

35781a2

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/services/solution_variables.py Outdated Show resolved Hide resolved

hpohekar added 3 commits

February 7, 2024 20:30


          solver and test update 2

0a07e5b


          solver and test update 3


          solver and test update 4

c2e1f3a

hpohekar marked this pull request as ready for review

February 7, 2024 15:19

hpohekar removed a link to an issue

version_info() -> git_version()/build_id() #2408

Closed

prmukherj reviewed

View reviewed changes

src/ansys/fluent/core/session_solver.py Show resolved Hide resolved

prmukherj reviewed

View reviewed changes

src/ansys/fluent/core/session_solver.py Show resolved Hide resolved

prmukherj reviewed

View reviewed changes

src/ansys/fluent/core/session_solver.py Show resolved Hide resolved

prmukherj reviewed

View reviewed changes

src/ansys/fluent/core/services/solution_variables.py Show resolved Hide resolved

prmukherj reviewed

View reviewed changes

src/ansys/fluent/core/services/solution_variables.py Show resolved Hide resolved

prmukherj reviewed

View reviewed changes

src/ansys/fluent/core/services/solution_variables.py Show resolved Hide resolved

prmukherj reviewed

View reviewed changes

src/ansys/fluent/core/services/solution_variables.py Show resolved Hide resolved

prmukherj reviewed

View reviewed changes

src/ansys/fluent/core/services/solution_variables.py Show resolved Hide resolved

prmukherj reviewed

View reviewed changes

src/ansys/fluent/core/services/solution_variables.py Show resolved Hide resolved

prmukherj reviewed

View reviewed changes

src/ansys/fluent/core/services/solution_variables.py Show resolved Hide resolved

prmukherj reviewed

View reviewed changes

src/ansys/fluent/core/services/solution_variables.py Show resolved Hide resolved

hpohekar and others added 6 commits

February 8, 2024 13:38


          revert version-info rename

71d0c5e


          add warnings 1

268e3f2


          add warnings 2

eb40670


          add warnings 3

d05a6e5


          make svar_service private

fb77490


          Merge branch 'main' into fix/rename_svar

63a0c96

seanpearsonuk reviewed

View reviewed changes

doc/source/api/solver/solution_variables.rst Outdated Show resolved Hide resolved

seanpearsonuk reviewed

View reviewed changes

doc/source/api/solver/solution_variables.rst Outdated Show resolved Hide resolved

mkundu1 reviewed

View reviewed changes

src/ansys/fluent/core/services/solution_variables.py Outdated Show resolved Hide resolved

hpohekar added 3 commits

February 12, 2024 13:13


          rename get_array

57afaf0


          Merge branch 'fix/rename_svar' of https://github.com/ansys/pyfluent i…

ae5cfca

…nto fix/rename_svar


          redesign

dc51be3

seanpearsonuk approved these changes

View reviewed changes

prmukherj approved these changes

View reviewed changes

mkundu1 reviewed

View reviewed changes

tests/test_svars.py Show resolved Hide resolved

mkundu1 approved these changes

View reviewed changes

hpohekar merged commit 1f5ab42 into main

hpohekar deleted the fix/rename_svar branch

February 12, 2024 14:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

seanpearsonuk seanpearsonuk approved these changes

mkundu1 mkundu1 approved these changes

prmukherj prmukherj approved these changes

ajain-work Awaiting requested review from ajain-work

dnwillia-work Awaiting requested review from dnwillia-work

h-krishnan Awaiting requested review from h-krishnan

raph-luc Awaiting requested review from raph-luc

Labels

None yet