feat: Backward compatibility for settings API #2448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
requested review from
ajain-work,
dnwillia-work,
h-krishnan,
hpohekar,
prmukherj,
raph-luc and
seanpearsonuk
as code owners
This was
linked to
issues
Feb 13, 2024
prmukherj
approved these changes
Feb 14, 2024
hpohekar
approved these changes
Feb 14, 2024
seanpearsonuk
approved these changes
Feb 14, 2024
mkundu1
commented
Feb 14, 2024
mkundu1
force-pushed
the
feat/backward-compatibility
branch
from
42b75ad to
9b51dda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the backward compatbility support in PyFluent settings API using the
child-aliases/command-aliases/query-aliasesattributes in settings API.A tree of alias-objects mimicking the original object tree is constructed on-access basis during runtime. For an object hierarchy
A -> B -> C, IfA1is an alias ofA,A1.BandA1.Care also aliases and the backward compatibility message for set_state is shown at all levels. The_Aliasbase class prints the backward compatibility message on various journaling points using the scheme_eval function which is passed through theget_root()function.Please see the Fluent side PR for more details on flobject.py change.
I'm also incorporating changes from #2428 which simplifies some code requiring access to original settings object classes.