-
Notifications
You must be signed in to change notification settings - Fork 57
Local surface provider. #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| """Base class for post objects.""" | ||
|
|
||
| def _pre_display(self): | ||
| local_surfaces_provider = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It creates local surface in Fluent.
| (), | ||
| ) | ||
|
|
||
| def _post_display(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It deletes local surface in Fluent.
| return list( | ||
| self._data_extractor.field_info().get_surfaces_info().keys() | ||
| ) | ||
| ) + list(self._get_top_most_parent()._local_surfaces_provider()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local surfaces become available along with surfaces in Fluent.
| assert range[0] == pytest.approx(iso_surf.iso_value()) | ||
|
|
||
| cont1 = pyvista_graphics.Contours["surf-1"] | ||
| assert "surf-1" in cont1.surfaces_list.allowed_values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surf-1 is now available.
|
|
||
| matplotlib_plots = Plots(session=None) | ||
| p1 = matplotlib_plots.XYPlots["p-1"] | ||
| assert "surf-1" not in p1.surfaces_list.allowed_values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default not available in matplotlib for xy plots.
|
|
||
| local_surfaces_provider = Graphics(session=None).Surfaces | ||
| matplotlib_plots = Plots(session=None, local_surfaces_provider=local_surfaces_provider) | ||
| assert "surf-1" in p1.surfaces_list.allowed_values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With local surface provider "surf-1" becomes available.
fa8caca to
adaa900
Compare
dnwillia-work
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's a local surface? Are you going to add documentation and examples?
adaa900 to
2bc21b9
Compare
2bc21b9 to
22c2ded
Compare
@dnwillia-work All object created under post module are local to client i.e. they are not created on server. So surfaces are also local. Yes will add examples. |
Local surfaces should be available for graphics and plot objects.