feat: Do not return boolean from settings API commands #2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
requested review from
ajain-work,
dnwillia-work,
h-krishnan,
hpohekar,
prmukherj,
raph-luc and
seanpearsonuk
as code owners
2 tasks
prmukherj
approved these changes
Feb 20, 2024
hpohekar
approved these changes
Feb 21, 2024
mkundu1
force-pushed
the
feat/no-return-bool
branch
from
c650a6d to
f14966d
Compare
mkundu1
force-pushed
the
feat/no-return-bool
branch
from
e1d47a4 to
3a54d43
Compare
seanpearsonuk
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress return value for a command if its
return-typeattribute in settings API is not specified.