fix: version check and scp reading when running inside a container #2502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochernuk
requested review from
ajain-work,
dnwillia-work,
h-krishnan,
hpohekar,
mkundu1,
prmukherj,
raph-luc and
seanpearsonuk
as code owners
raph-luc
reviewed
Feb 27, 2024
raph-luc
reviewed
Feb 28, 2024
PipKat
reviewed
Feb 28, 2024
Updated doc string based on feedback Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
…sys/pyfluent into system_coupling_version_check
dnwillia-work
approved these changes
Feb 28, 2024
raph-luc
approved these changes
Feb 28, 2024
ochernuk
changed the title
PipKat
reviewed
Feb 29, 2024
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Fluent within a container, the version check in System Coupling module was throwing an exception. Fixed by using the correct version query.
SCP file written by Fluent needs to be downloaded so it can be read in by PyFluent. Adjusted the code to use that.