refactor: session #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

prmukherj merged 25 commits into main from maint/refactor_session

Mar 15, 2024

Collaborator

prmukherj commented Mar 13, 2024 •

edited

Loading

Refactoring the methods exposed in session level.


          Refactor: session

caca29d

prmukherj linked an issue

that may be closed by this pull request

Interface segregation for session classes #2558

Closed

prmukherj changed the title ~~Refactor: session~~ refactor: session

prmukherj added 2 commits

March 13, 2024 16:29


          Refactoring.

6d16a2b


          Make error_state private.

d9dac12

mkundu1 reviewed

View reviewed changes

src/ansys/fluent/core/solver/flobject.py Outdated Show resolved Hide resolved


          Fix bug.

a8d7b12

prmukherj marked this pull request as ready for review

March 13, 2024 13:55

prmukherj requested review from ajain-work, dnwillia-work, h-krishnan, hpohekar, raph-luc and seanpearsonuk as code owners

March 13, 2024 13:55

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/fluent_connection.py Show resolved Hide resolved

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/session.py Outdated Show resolved Hide resolved

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/session.py Show resolved Hide resolved

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/session_solver.py Show resolved Hide resolved

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/session_solver.py Outdated Show resolved Hide resolved

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/session_solver.py Outdated Show resolved Hide resolved

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/session_solver.py Outdated Show resolved Hide resolved

prmukherj and others added 2 commits

March 13, 2024 22:24


          Correct docstrings.

c377422


          Merge branch 'main' into maint/refactor_session

4e202a1

wiz-inc-572fc38784 bot commented Mar 14, 2024 •

edited

Loading

Wiz Scan Summary


IaC Misconfigurations
Vulnerabilities
Sensitive Data
Total
Secrets

prmukherj and others added 2 commits

March 14, 2024 18:26


          Merge branch 'main' into maint/refactor_session

d63a504


          root -> settings

cd05dbe

PipKat reviewed

View reviewed changes

src/ansys/fluent/core/session.py Outdated Show resolved Hide resolved

PipKat reviewed

View reviewed changes

src/ansys/fluent/core/session.py Outdated Show resolved Hide resolved

PipKat reviewed

View reviewed changes

src/ansys/fluent/core/session_solver.py Outdated Show resolved Hide resolved

PipKat reviewed

View reviewed changes

src/ansys/fluent/core/session_solver.py Outdated Show resolved Hide resolved

prmukherj added 5 commits

March 14, 2024 22:08


          Renaming and restructuring.

23cb60b


          Update tests.

65176fa


          Add test.


          Doc update.

06a17bd


          include is_active check.

d91e29d

prmukherj closed this

prmukherj reopened this

prmukherj removed a link to an issue

Use value of webui-release-active? to warn of beta API use #2574

Closed


          Ignore Stability check.

90e0d5b

mkundu1 approved these changes

View reviewed changes

hpohekar approved these changes

View reviewed changes

prmukherj and others added 10 commits

March 15, 2024 10:01


          Fix tests.

1ea3907


          Updated field data test.

1d1cc5a


          Update dir.

abb6dce


          Update src/ansys/fluent/core/session.py

fda10b8

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>


          Update src/ansys/fluent/core/session.py

e43ea16

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>


          Update src/ansys/fluent/core/session_solver.py

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>


          Update src/ansys/fluent/core/session.py

6e1ac7c

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>


          Update src/ansys/fluent/core/solver/flobject.py

da65719

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>


          Update docstrings.

48b7d67


          Merge branch 'main' into maint/refactor_session

63b542a

prmukherj closed this

prmukherj reopened this

prmukherj enabled auto-merge (squash)

March 15, 2024 08:39

prmukherj disabled auto-merge

March 15, 2024 08:39

seanpearsonuk approved these changes

View reviewed changes

prmukherj merged commit 1bb181f into main

prmukherj deleted the maint/refactor_session branch

March 15, 2024 11:10

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/session_solver.py

    
                      self._tui_service = self.datamodel_service_tui

                      self._se_service = self.datamodel_service_se

                      self._settings_service = self.settings_service

                      self._settings_service = self._settings_service

Collaborator

seanpearsonuk Dec 10, 2024

@prmukherj This line looks redundant

seanpearsonuk mentioned this pull request

@prmukherj This line looks redundant #3561

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

PipKat PipKat left review comments

seanpearsonuk seanpearsonuk approved these changes

mkundu1 mkundu1 approved these changes

hpohekar hpohekar approved these changes

ajain-work Awaiting requested review from ajain-work

dnwillia-work Awaiting requested review from dnwillia-work

h-krishnan Awaiting requested review from h-krishnan

raph-luc Awaiting requested review from raph-luc

Labels

None yet