Field data refactoring. #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajain-work
commented
Apr 11, 2022
ajain-work
commented
Apr 11, 2022
ajain-work
commented
Apr 11, 2022
ajain-work
force-pushed
the
feat/field_data_payload_tag
branch
from
45c3968 to
8c06ad4
Compare
ajain-work
commented
Apr 11, 2022
ajain-work
commented
Apr 11, 2022
ajain-work
commented
Apr 11, 2022
| if location_tag & payload_info and ( | ||
| not boundary_value_tag or (boundary_value_tag & payload_info) | ||
| ): | ||
| xyplot_data = payload_data |
There was a problem hiding this comment.
Data is retrieved from the tag.
ajain-work
force-pushed
the
feat/field_data_payload_tag
branch
from
8c06ad4 to
6e19bda
Compare
ajain-work
force-pushed
the
feat/field_data_payload_tag
branch
from
6e19bda to
a6a57a9
Compare
dnwillia-work
requested changes
Apr 11, 2022
There was a problem hiding this comment.
Make sure to format the proto file with clang format. The options are defined at
https://github.com/pyansys/pyfluent/blob/main/protos/.clang_format
I had been doing that before merging the files back to the Fluent repo. If you happen to use Visual Studio Code it comes with the cpptools extension:
C:\Users\dnwillia.vscode\extensions\ms-vscode.cpptools-1.9.7-win32-x64\LLVM\bin\clang-format.exe
ajain-work
force-pushed
the
feat/field_data_payload_tag
branch
from
a6a57a9 to
dcece5d
Compare
ajain-work
commented
Apr 12, 2022
ajain-work
commented
Apr 12, 2022
dnwillia-work
approved these changes
Apr 12, 2022
seanpearsonuk
approved these changes
Apr 12, 2022
ajain-work
force-pushed
the
feat/field_data_payload_tag
branch
from
dcece5d to
a2cbd9b
Compare
Merged
mkundu1
approved these changes
Apr 14, 2022
ajain-work
force-pushed
the
feat/field_data_payload_tag
branch
3 times, most recently
from
96adb94 to
38b94a7
Compare
ajain-work
force-pushed
the
feat/field_data_payload_tag
branch
from
38b94a7 to
73a2106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following are the issues in field_data APIs:
For example, to draw XY plot for element values, two requests will be sent by client:
So not only client has to make two requests, but will also get redundant data e.g. vertices and faces connectivity. So instead of get APIs, there should be addRequest APIs. It shall give complete flexibility.
Also tags are introduced to provide extra information about fields.
Important: Unit tests updated.