Proto corrected. #309
Closed
Proto corrected. #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
approved these changes
Apr 14, 2022
| rpc executeCommand(ExecuteCommandRequest) returns (ExecuteCommandResponse) {} | ||
| rpc getSpecs(GetSpecsRequest) returns (GetSpecsResponse) {} | ||
| rpc getStaticInfo(GetStaticInfoRequest) returns (GetStaticInfoResponse) {} | ||
| rpc initDatamodel(InitDatamodelRequest) returns (InitDatamodelResponse) { |
There was a problem hiding this comment.
This one is a bit annoying isn't it? I wonder if AllowShortBlocksOnASingleLine: Empty would help here.
There was a problem hiding this comment.
Strange though, when I format the files it does not do that. Here's my commands:
D:\ANSYSDev\NoBackup\pyansys\pyfluent\protos\ansys\api\fluent\v0>clang-format -style=file datamodel_se.proto > output.txt
D:\ANSYSDev\NoBackup\pyansys\pyfluent\protos\ansys\api\fluent\v0>move /y output.txt datamodel_se.proto
1 file(s) moved.
D:\ANSYSDev\NoBackup\pyansys\pyfluent\protos\ansys\api\fluent\v0>clang-format -version
clang-format version 13.0.0 (https://github.com/llvm/llvm-project d7b669b3a30345cfcdb2fde2af6f48aa4b94845d)
Diffs on this proto look like this:
There was a problem hiding this comment.
I added the extra option in #310 and moved the options file up one level in case we use it for other things.
|
@ajain-work I guess we can abandon this one since pre-commit is configured instead now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.