Add support of pythreejs as a backend of pyvista and support for Python 3.9. #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
reviewed
Apr 15, 2022
mkundu1
approved these changes
Apr 15, 2022
Co-authored-by: Mainak Kundu <94432368+mkundu1@users.noreply.github.com>
ajain-work
approved these changes
Apr 18, 2022
|
@jerome-blanche I think you just need to rebase this because we switched to the 'src' layout recently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support of pythreejs as a backend of pyvista and support for Python 3.9.
A PyVista VTK wheel exists for Python 3.9: https://github.com/pyvista/pyvista-wheels/blob/main/vtk-osmesa-9.1.0-cp39-cp39-linux_x86_64.whl.
This uses OSMesa and avoids using xvfb, which has been found to be unstable and has lower performance.
When pythreejs is the backend, clearing the plotter deletes too many objects, which ends with 3D models without colors.
Removing only the former actors from the plotter before adding the new ones fixes the issue.