-
Notifications
You must be signed in to change notification settings - Fork 56
Create multiple docker images for fluent. One for solver and another with cad #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
COPY cad.tgz /ansys_inc/ | ||
RUN tar -xzf /ansys_inc/cad.tgz --directory /ansys_inc/ && rm -f /ansys_inc/cad.tgz | ||
|
||
FROM ghcr.io/pyansys/pyfluent-solver:latest AS fluent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, so is this taking the first image and incorporating here? If so, I think the ci config will need updating to pull this image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Using the solver image to add to it the cad piece.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need to update this:
https://github.com/pyansys/pyfluent/blob/6f11be964fd8db511f5e2b53a3b0f404b584a1b7/Makefile#L25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think I need to update this. The docker pull command will be installing ghcr.io/pyansys/pyfluent:latest which will be the fluent + nexus + cad ( full fluent )
docker should pull ghcr.io/pyansys/pyfluent-solver:latest which will be just fluent + nexus when installing the full fluent
Unless we want to have a Makefile for fluent-solver & fluent-solver + cad ( full fluent )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, good and we can leave the makefile as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a thought of creating docker images of the 3 tgz files ( cad, cei, fluent ) in github
Then have dockerfiles to create the images from the tgz images. Based on the 3 tgz files, we could create 3 images if we need to.
base fluent solver: fluent tgz image
base fluent solver + parametric: fluent + cei tgz images
base fluent solver + parametric + meshing: fluent + cei + cad tgz images
Wondering if there is any interest in this approach. I will not merge this PR if there is interest in this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be ok but splitting out CEI probably only makes sense if we also deactivate the dependent part of the API. So, we would need to do both bits of work. I think you could leave it aside for now.
@lxjanoo Sean is away this week so I force merged the changes. |
There will be 2 images created for fluent. Images created
dockerfiles
The tgz files to create the images are defined in a txt file
ceiList.txt list of nexus files
fluentList.txt list for fluent files for standalone fluent
cadList.txt List of meshing files needed by fluent
Steps to create images:
REPOSITORY TAG IMAGE ID CREATED SIZE
ghcr.io/pyansys/pyfluent latest e3e02d29b00a 2 hours ago 15.3GB
ghcr.io/pyansys/pyfluent-solver latest dab4309453de 2 hours ago 8.52GB
Ran basic test to import cad and run a solver journal file.