Skip to content

feat: Use 'deprecated-version' flag for settings-api classes #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Mar 10, 2025
Merged

feat: Use 'deprecated-version' flag for settings-api classes #3802

merged 18 commits into from
Mar 10, 2025

Conversation

@prmukherj
Copy link
Collaborator

@prmukherj prmukherj commented Mar 4, 2025 •
edited
Loading

Use 'deprecated-version' flag for settings-api classes. The flag is specific to Fluent version.

@github-actions github-actions bot added the new feature Request or proposal for a new feature label Mar 4, 2025
prmukherj
prmukherj commented Mar 5, 2025
View reviewed changes
prmukherj
prmukherj commented Mar 5, 2025
View reviewed changes
@prmukherj prmukherj marked this pull request as ready for review March 5, 2025 09:17
seanpearsonuk
seanpearsonuk reviewed Mar 5, 2025
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Mar 5, 2025
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Mar 5, 2025
View reviewed changes
seanpearsonuk
seanpearsonuk approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@seanpearsonuk seanpearsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks right but it would be good for others to check closely.

@github-actions
Copy link

github-actions bot commented Mar 5, 2025

The towncrier template has been successfully rewritten with the default template.
Please ensure that sphinx-design is included as a dependency in your project's documentation requirements.
Additionally, add sphinx-design to the extensions list in your conf.py file.
For more information, please refer to the migration guide at:
https://actions.docs.ansys.com/version/stable/migrations/index.html#migration-guide

mkundu1
mkundu1 reviewed Mar 5, 2025
View reviewed changes
@prmukherj prmukherj merged commit 39e7009 into main Mar 10, 2025
34 of 35 checks passed
@prmukherj prmukherj deleted the feat/use_deprecated_flag_for_settings_api branch March 10, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@mkundu1 mkundu1 mkundu1 approved these changes

@hpohekar hpohekar Awaiting requested review from hpohekar hpohekar is a code owner

Assignees

No one assigned

Labels

new feature Request or proposal for a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@prmukherj @seanpearsonuk @mkundu1 @pyansys-ci-bot