Skip to content

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented May 10, 2022

The new workflow will run daily and will create a PR if it detects any change in the generated API code.

@mkundu1 mkundu1 force-pushed the maint/update-solver-api branch from 33257b3 to bc93858 Compare May 10, 2022 10:29
Auto-generated by [create-pull-request][1]

[1]: https://github.com/peter-evans/create-pull-request
branch: feat/update-solver-api
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, you activate this by creating a branch with this name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch should also be automatically created by this action as per the doc.

(I'm yet to test this in github. There doesn't seem to be a way to run new workflows from a branch in github. So we can check how this is working in its first scheduled run after the PR is merged.)

Copy link
Collaborator

@dnwillia-work dnwillia-work May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, ok, I see you have it on a cron schedule, but it's not clear to me then how it 'detects' if there is an API change requiring regeneration of the code.

@mkundu1 mkundu1 merged commit 810178b into main May 10, 2022
@mkundu1 mkundu1 deleted the maint/update-solver-api branch May 10, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants