Skip to content

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented May 11, 2022

No description provided.

@mkundu1 mkundu1 changed the title Feat/api hierarchy Update API hierarchy May 11, 2022
@mkundu1 mkundu1 linked an issue May 11, 2022 that may be closed by this pull request
@mkundu1 mkundu1 force-pushed the feat/api-hierarchy branch 2 times, most recently from 9478857 to 46d01da Compare May 12, 2022 00:10
Copy link
Collaborator

@dnwillia-work dnwillia-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to tag for ECC before merging this?

@mkundu1 mkundu1 force-pushed the feat/api-hierarchy branch from 46d01da to b246ffa Compare May 12, 2022 05:46
@seanpearsonuk
Copy link
Collaborator

I guess we need to tag for ECC before merging this?

Yes, we do

@mkundu1 mkundu1 force-pushed the feat/api-hierarchy branch from b246ffa to b59338d Compare May 12, 2022 11:55
@mkundu1 mkundu1 merged commit 2f8fc10 into main May 13, 2022
@mkundu1 mkundu1 deleted the feat/api-hierarchy branch May 13, 2022 02:01
# Set number of iterations to 100

session.tui.solver.solve.set.number_of_iterations("100")
session.solver.tui.solve.set.number_of_iterations("100")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it easier to maintain, could we have at the top of the file: solver = session.solver.tui, so all commands below can refer to this 'solver' variable? For a future change, it would be faster to update

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @valeriegelbgras

Yes, the example script should have been written that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hierarchy of APIs

3 participants