Skip to content

refactor: Rename meshing_rule_file_names and update docker files [skip tests] #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 6, 2025
Merged

refactor: Rename meshing_rule_file_names and update docker files [skip tests] #4112

merged 6 commits into from
Jun 6, 2025

Conversation

@hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Jun 5, 2025 •
edited
Loading

closes #3894, #3889, #4101

  1. Rename meshing_rule_file_names to datamodel_file_name_map.
  2. Update mode argument docstring.
  3. Update Dockerfiles to fix an environment variable.
  4. Update outdated link in Docker docs.

@github-actions github-actions bot added the enhancement Improve any current implemented feature label Jun 5, 2025
@hpohekar hpohekar linked an issue Jun 5, 2025 that may be closed by this pull request
mode argument for launch_fluent documented purely as string #3889
Closed
@hpohekar hpohekar changed the title refactor: Rename meshing_rule_file_names [skip tests] refactor: Rename meshing_rule_file_names and update docker files [skip tests] Jun 6, 2025
@hpohekar hpohekar linked an issue Jun 6, 2025 that may be closed by this pull request
Bug located in pyfluent/docker/fluent_*/Dockerfile #4101
Closed
2 tasks
@hpohekar hpohekar enabled auto-merge (squash) June 6, 2025 05:16
@hpohekar hpohekar merged commit 996ac17 into main Jun 6, 2025
64 of 70 checks passed
@hpohekar hpohekar deleted the refator/update_variable_name branch June 6, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@prmukherj prmukherj prmukherj approved these changes

@mkundu1 mkundu1 Awaiting requested review from mkundu1 mkundu1 is a code owner

Assignees

No one assigned

Labels

enhancement Improve any current implemented feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug located in pyfluent/docker/fluent_*/Dockerfile meshing_rule_file_names variable mode argument for launch_fluent documented purely as string

5 participants

@hpohekar @seanpearsonuk @prmukherj @pyansys-ci-bot