Adding settings based api example, and other changes #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatel-qa
requested review from
akulshre-qa,
dnwillia-work,
mkundu1 and
seanpearsonuk
akulshre-qa
approved these changes
May 23, 2022
dnwillia-work
approved these changes
May 24, 2022
seanpearsonuk
added a commit
that referenced
this pull request
May 30, 2022
* allow show gui via arg * allow show gui via arg - tweaked te logic * correct comment following logic change * Update src/ansys/fluent/core/launcher/launcher.py Co-authored-by: Dan Williams <dan.williams@ansys.com> * remove code that differs in style * change == to is (review comment) * Adding settings based api example, and other changes (#428) * Adding settings based api example, and other changes * Titles fix * Fixing convergance issue. Removing pandas. * Fixing typo * Adding exit commands, thubnail image * Style check fix * Upgrade to protobuf==3.20.1 * allow show gui via arg * allow show gui via arg - tweaked te logic * correct comment following logic change * remove code that differs in style * Update src/ansys/fluent/core/launcher/launcher.py Co-authored-by: Dan Williams <dan.williams@ansys.com> * change == to is (review comment) Co-authored-by: Dan Williams <dan.williams@ansys.com> Co-authored-by: Yogesh Patel <97630098+ypatel-qa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.