Feat/pypim #445
Merged
Feat/pypim #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _THIS_DIR = os.path.dirname(__file__) | ||
| _OPTIONS_FILE = os.path.join(_THIS_DIR, "fluent_launcher_options.json") | ||
| FLUENT_VERSION = "22.2" | ||
| PIM_FLUENT_PRODUCT_VERSION = FLUENT_VERSION.replace(".", "") |
There was a problem hiding this comment.
Does it need to be public?
Suggested change
| PIM_FLUENT_PRODUCT_VERSION = FLUENT_VERSION.replace(".", "") | |
| _PIM_FLUENT_PRODUCT_VERSION = FLUENT_VERSION.replace(".", "") |
There was a problem hiding this comment.
Does it need to be public?
The only reason was that it is accessed in the added test. So, it's a moot point perhaps.
There was a problem hiding this comment.
Yeah ok, I see it now. If it's on purpose that's fine.
| if start_transcript: | ||
| self.start_transcript() | ||
|
|
||
| self._remote_instance = remote_instance |
There was a problem hiding this comment.
Is there a reason this is there 2x?
There was a problem hiding this comment.
No, this is a bad merge, resolving conflicts
mkundu1
approved these changes
May 31, 2022
ajain-work
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, PyPIM is integrated into PyFluent. This means that there is no special PyPIM code to insert into Jupyter Notebooks for PyFluent on Fuji, making those notebooks more portable.
PyMADL has already made a similar adoption into its launch code.
Subsequent work can add dependency on the uploader service to take explicit file upload/download operations out of the hands of users and make file IO operations in notebooks portable also.
Testing;
added unit test
tested on Ansys Lab, removing explicit use of PyPIM there.