Skip to content

Conversation

@mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Oct 10, 2025

Context

The method __call__ used to only get the state for parameters. For some recently modified parameter definitions in settings API, we need to set the state if any argument is passed to __call__ to support backward compatibility. This was already implemented for groups.

Change Summary

Both groups and parameters should set the state if any argument is passed to the __call__ method.

Rationale

The requirement follows from the settings API.

Impact

Will fix the doc example exhaust_system_settings_api which has been failing in 26.1.

@Copilot Copilot AI review requested due to automatic review settings October 10, 2025 12:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes the __call__ method in the SettingsBase class to support setting state when arguments are passed, providing backward compatibility for recently modified parameter definitions in the settings API.

  • Moves the __call__ implementation from the Group class to the base SettingsBase class
  • Updates the method signature to accept arguments and handle both getting and setting state
  • Removes the duplicate implementation from the Group class to eliminate code duplication

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mkundu1 mkundu1 linked an issue Oct 10, 2025 that may be closed by this pull request
@github-actions github-actions bot added the bug Issue, problem or error in PyFluent label Oct 10, 2025
@Copilot Copilot AI review requested due to automatic review settings October 20, 2025 12:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Copilot Copilot AI review requested due to automatic review settings October 20, 2025 12:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 18:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 20:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 20:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mkundu1
Copy link
Contributor Author

mkundu1 commented Oct 21, 2025

@mkundu1 mkundu1 merged commit 39bf3a2 into main Oct 21, 2025
4 checks passed
@mkundu1 mkundu1 deleted the fix/call branch October 21, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyFluent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing example in Nightly Dev Doc Build

6 participants