PyFluent dash gui. #470
Merged
PyFluent dash gui. #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajain-work
commented
Jun 8, 2022
| cls.set_flproxy(flproxy) | ||
| return cls() | ||
| root = cls() | ||
| root.set_flproxy(flproxy) |
There was a problem hiding this comment.
proxy must be set for each object. Otherwise all sessions will point to same server.
ajain-work
commented
Jun 8, 2022
| for argument in self.argument_names: | ||
| cls = getattr(self.__class__, argument) | ||
| setattr(self, argument, cls(None, self)) | ||
| self._initialized = True |
There was a problem hiding this comment.
Command initialization part was missing. Without this command members can not be accessed.
ajain-work
commented
Jun 8, 2022
|
|
||
| _flproxy = None | ||
|
|
||
| @classmethod |
There was a problem hiding this comment.
Should not be a class method.
mkundu1
reviewed
Jun 8, 2022
| "numpy>=1.21.5", | ||
| "protobuf==3.20.1", | ||
| "appdirs>=1.4.0", | ||
| "pandas>=1.4.1" if sys.version_info.minor > 7 else "pandas==1.3.5", |
There was a problem hiding this comment.
I think this is equivalent to pandas>=1.3.5.
mkundu1
approved these changes
Jun 8, 2022
seanpearsonuk
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monitors and event streaming related changes.