Run tests and doc build for 23.1 docker #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
commented
Jul 27, 2022
|
@akulshre-qa We need to make sure 23.1 specific tests are running with 23.1 image only (possibly using a marker). |
Do we need to make changes in makefile to do this? |
akulshre-qa
approved these changes
Jul 27, 2022
Yes, I've created #681 to cover it. |
seanpearsonuk
approved these changes
Jul 28, 2022
hpohekar
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the 22.2 artifacts have been uploaded.
One concern could be that the CI log is showing all settings API filenames (we should hide any 23.1 solver details).