-
Notifications
You must be signed in to change notification settings - Fork 56
Provide users option to set fluent version #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
be12338
Provide users option to set fluent version
prmukherj 6f1d20d
Updated FLUENT_VERSION into a list
prmukherj 280d9a0
Error handling logic implemented
prmukherj 8e85d82
Updated error handling for fluent exe path
prmukherj 810058f
Added test cases for testing path and version setting
prmukherj 7f48e93
Updated the checking with Path.exists()
prmukherj 79d7893
str -> Path
prmukherj 3ad403f
Merge branch 'main' into feat/set_fluent_version
prmukherj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import pytest | ||
|
||
import ansys.fluent.core as pyfluent | ||
from ansys.fluent.core.launcher.launcher import FLUENT_VERSION | ||
|
||
|
||
def test_manual_fluent_version_setting(): | ||
"""Test case for setting up the Ansys / Fluent version via program""" | ||
pyfluent.set_ansys_version("23.1") | ||
assert FLUENT_VERSION[0] == "23.1" | ||
|
||
pyfluent.set_ansys_version(22.2) | ||
assert FLUENT_VERSION[0] == "22.2" | ||
|
||
pyfluent.set_ansys_version(version=pyfluent.FluentVersion.version_23R1) | ||
assert FLUENT_VERSION[0] == "23.1" | ||
|
||
# version does not exist | ||
with pytest.raises(RuntimeError): | ||
pyfluent.set_ansys_version(22.1) | ||
|
||
|
||
def test_manual_fluent_path_setting(): | ||
"""Test case for setting up the path to fluent.exe via program""" | ||
with pytest.raises(RuntimeError): | ||
pyfluent.set_fluent_path("X:/dir_1/dir2/xxx.exe") | ||
|
||
with pytest.raises(RuntimeError): | ||
pyfluent.set_fluent_path("X:/dir_1/dir2/fluent.bat") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.