update dir, remove some redundant code #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpearsonuk
commented
Aug 16, 2022
|
|
||
| def __dir__(self): | ||
| return sorted( | ||
| set(list(self.__dict__.keys()) + dir(type(self)) + dir(self._task)) |
There was a problem hiding this comment.
add this object's attributes, the class attributes (which brings in methods), and attributes inherited from the task
seanpearsonuk
commented
Aug 16, 2022
|
|
||
| def __dir__(self): | ||
| return sorted( | ||
| set(list(self.__dict__.keys()) + dir(type(self)) + dir(self._workflow)) |
There was a problem hiding this comment.
similar logic to the above
mkundu1
pushed a commit
that referenced
this pull request
Aug 24, 2022
* got the command server -> client * still got the command server -> client * got the command server -> client * got the command server -> client * got the command server -> client * got the command server -> client * safely delete cmd args * add MeshingWorkflow class * got the command server -> client * still got the command server -> client * got the command server -> client * got the command server -> client * got the command server -> client * got the command server -> client * safely delete cmd args * update meshing workflow class * workflow class is working * got the command server -> client * still got the command server -> client * got the command server -> client * got the command server -> client * got the command server -> client * got the command server -> client * safely delete cmd args * update meshing workflow class * workflow class is working * got the command server -> client * still got the command server -> client workflow * got the command server -> client * workflow * got the command server -> client * workflow * workflow * workflow * workflow * workflow * workflow * task attribute support * reversion * reversion * reversion * workflow * workflow * fix name * log * Update test_pure_mesh_vs_mesh_workflow.py revert * Update workflow.py * minor style update * update dir, remove some redundant code (#725) * update dir, remove some redundant code * extend testing * Update test_session.py * add call op in wf class Co-authored-by: Prithwish Mukherjee <prithwish.mukherjee@ansys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__dir__in a few places because some elements are missing where they are attributes of other attributes. The original PR uses__getattr__in those places which leaves things missing fromdir()results.