Log panic file contents on worker failure #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimanikant
requested review from
FedericoNegri,
nezgrath and
ojkoenig
as code owners
…nto mguntupa/panic
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
- Coverage 84.16% 83.81% -0.36%
==========================================
Files 17 17
Lines 1503 1538 +35
==========================================
+ Hits 1265 1289 +24
- Misses 238 249 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nezgrath
reviewed
Oct 14, 2025
|
|
||
| def _monitor(self): | ||
| restart_count = 0 # Initialize a counter for restarts | ||
| max_restarts = 5 # Set the maximum number of restarts |
Collaborator
There was a problem hiding this comment.
Maybe we should make this configurable?
nezgrath
reviewed
Oct 14, 2025
| # log.debug("Worker log output stopped") | ||
|
|
||
| def _monitor(self): | ||
| restart_count = 0 # Initialize a counter for restarts |
Collaborator
There was a problem hiding this comment.
Would it make sense to reset this when a worker starts up successfully?
nezgrath
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes include:
Regenerate the pydantic models
grab location of panic file - ping the status endpoint
if worker dies then (warning):
check greater than 0
readin line by line or limiting the size of the message (look at splitting on an empty line)
Feed panic file into logging (at warning level) for DCS Monitor, OTEL to pick up
qLimit restarts of worker to x (5)
Checklist