New VM example on NRC Piping Benchmarks: NUREG/CR-1677 #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
germa89
approved these changes
Aug 22, 2025
Contributor
germa89
left a comment
germa89
left a comment
There was a problem hiding this comment.
Few minor suggestions. Most important is to use figure instead of image.
Also, I would recommend you to use tabulate when possible.
Very good work!
germa89
reviewed
Aug 22, 2025
germa89
approved these changes
Aug 22, 2025
Contributor
germa89
left a comment
germa89
left a comment
There was a problem hiding this comment.
Forgot to add some more comments.
Again, good work. Some changes I proposed here might be a bit too much because they will stray away from the original example however I do think they improve readability, so feel free to discard them if you prefer to keep closer to the original VM.
minor correction in the description Co-authored-by: German <28149841+germa89@users.noreply.github.com>
minor correction in the title Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
adding native larc API of PyMAPDL Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@clatapie new verification manual example on "NRC Piping Benchmarks: NUREG/CR-1677: Volume 1, Benchmark Problem No. 1" has been added for your review. Please modify it, if required, to render it properly in our documentation. Thanks!