Avoiding nodes mapping in PyMAPDL. #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1005 +/- ##
==========================================
+ Coverage 74.75% 74.79% +0.03%
==========================================
Files 43 43
Lines 6045 6050 +5
==========================================
+ Hits 4519 4525 +6
+ Misses 1526 1525 -1 |
akaszynski
reviewed
Mar 30, 2022
germa89
added a commit
that referenced
this pull request
Apr 20, 2022
* Adding sanity check and default dtype to `get_vec` * Removing not allowed keywords. * Ensuring returning type when using `asarray` argument * Adding unit tests * Fixing unit tests * Adding asarray arg to test. * Update src/ansys/mapdl/core/math.py Co-authored-by: Alex Kaszynski <akascap@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #990
You can still operate with these mappings but it should be done using
mapdl.run("*SMAT...."). This allows to work inside MAPDL with these nodes mapping.Also adding default
dtypefor theget_vecwhen usingBACKandFORWARDsince MAPDL returns ints arrays.Also, to avoid possible errors, I'm forcing array conversion (
array.astype) when usingget_vecandasarraykeyword.