Skip to content

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 29, 2022

Minor improvements.

Also added clean arg to make.bat from ansys/pyansys-tools-report#2

@germa89 germa89 added this to the v0.62.0 milestone Apr 29, 2022
@germa89 germa89 self-assigned this Apr 29, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #1084 (e2eba8c) into main (c8147a9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1084   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          43       43           
  Lines        6428     6428           
=======================================
  Hits         4713     4713           
  Misses       1715     1715           

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance labels May 3, 2022
@akaszynski
Copy link
Collaborator

Looks like docs are picking up on warnings:

WARNING: [numpydoc] Validation warnings while processing docstring for 'ansys.mapdl.core.Report.architecture':
  SS02: Summary does not start with a capital letter

WARNING: [numpydoc] Validation warnings while processing docstring for 'ansys.mapdl.core.Report.date':
  GL08: The object does not have a docstring

WARNING: [numpydoc] Validation warnings while processing docstring for 'ansys.mapdl.core.Report.platform':
  GL08: The object does not have a docstring

WARNING: [numpydoc] Validation warnings while processing docstring for 'ansys.mapdl.core.Report.python_environment':
  GL08: The object does not have a docstring

WARNING: [numpydoc] Validation warnings while processing docstring for 'ansys.mapdl.core.Report.sys_version':
  GL08: The object does not have a docstring

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@germa89 germa89 merged commit 24549fa into main May 6, 2022
@germa89 germa89 deleted the fix/converter-docs branch May 6, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants