Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 13, 2025

Description

As the title. When using components with many numbers, this line used to give errors.

Issue linked

Close #4243

Checklist

@germa89 germa89 requested a review from a team as a code owner October 13, 2025 15:38
@germa89 germa89 requested review from clatapie, Copilot and pyansys-ci-bot and removed request for Copilot October 13, 2025 15:38
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Oct 13, 2025
Copilot AI review requested due to automatic review settings October 13, 2025 15:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.27%. Comparing base (a726314) to head (5df3bc4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4257      +/-   ##
==========================================
- Coverage   91.30%   91.27%   -0.04%     
==========================================
  Files         193      193              
  Lines       15719    15720       +1     
==========================================
- Hits        14353    14348       -5     
- Misses       1366     1372       +6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 enabled auto-merge (squash) October 15, 2025 09:35
@germa89
Copy link
Collaborator Author

germa89 commented Oct 15, 2025

@pyansys-ci-bot LGTM

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 4cde775 into main Oct 15, 2025
50 checks passed
@germa89 germa89 deleted the fix/mesh-printing-number-of-nodes branch October 15, 2025 09:35
clatapie pushed a commit that referenced this pull request Oct 15, 2025
* fix: filter non-numeric values when parsing item list

* chore: adding changelog file 4257.fixed.md [dependabot-skip]

* test: add test for creating a large component with many nodes

* test: replace unnecessary f-string with plain string in test_big_component

---------

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mapdl.mesh command fails

3 participants