Skip to content

fix: cicd mpi issue and adding conditional encrypted log uploads #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Nov 26, 2025
Merged

fix: cicd mpi issue and adding conditional encrypted log uploads #4319

merged 29 commits into from
Nov 26, 2025
+128 −34

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 21, 2025

Attemp to fix cicd.

Copilot AI review requested due to automatic review settings November 21, 2025 14:35
Copilot AI reviewed Nov 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Nov 21, 2025
@pyansys-ci-bot pyansys-ci-bot requested a review from a team as a code owner November 21, 2025 14:36
@codecov
Copy link

codecov bot commented Nov 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.35%. Comparing base (8efc45e) to head (f5eecfa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4319      +/-   ##
==========================================
+ Coverage   91.27%   91.35%   +0.08%     
==========================================
  Files         193      193              
  Lines       15742    15742              
==========================================
+ Hits        14368    14381      +13     
+ Misses       1374     1361      -13
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89
Copy link
Collaborator Author

germa89 commented Nov 24, 2025

Identified problems with Local-min-console and Local-min.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Nov 25, 2025
germa89 added 16 commits November 25, 2025 11:06
@germa89
chore: clean up whitespace in workflow YAML files
801fef7
@germa89
feat: add upload logs option for local and remote testing workflows
9cec690
@germa89
feat: add log encryption key to CI jobs for enhanced security
5fcf6e2
@germa89
fix: set upload-logs to true in CI jobs for consistent logging
fe344ce
@germa89
fix: remove unnecessary './' prefix from log file paths in display_lo…
aaa0b3e 
…gs_locals.sh
@germa89
fix: update ubuntu version identifiers in build_matrix.sh for consist…
7a850f8 
…ency
@germa89
fix: enhance log display in display_logs_remote.sh for better debugging
29d0ade
@germa89
fix: add MPI environment variable for CICD version in start_mapdl.sh
3f64cae
@germa89
fix: add MPI switches for CICD version in test-local workflow
692964e
@germa89
fix: quote MPI variable in docker run command for proper handling
282ef46
@germa89
fix: remove quotes around MPI variable in docker run command for prop…
5d01e36 
…er execution
@germa89
fix: remove quotes around MPI switches in CICD testing for proper env…
bbbc830 
…ironment variable handling
@germa89
fix: remove quotes around LOG_NAMES variable in log display scripts f…
f6c71b5 
…or consistency
@germa89
fix: reduce maxfail and reruns in pytest arguments for local and remo…
9795ef3 
…te testing
@germa89
fix: add MAPDL_IMAGE environment variable to start_mapdl.sh for Docke…
c637c1c 
…r container
@germa89
fix: update mapdl-version in CI configuration for consistency across …
c07b830 
…builds
@germa89
Copy link
Collaborator Author

germa89 commented Nov 26, 2025

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) November 26, 2025 14:09
@germa89 germa89 disabled auto-merge November 26, 2025 14:09
pyansys-ci-bot
pyansys-ci-bot approved these changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 changed the title fix: cicd fix: cicd mpi issue and adding conditional encrypted log uploads Nov 26, 2025
@germa89 germa89 enabled auto-merge (squash) November 26, 2025 14:16
@germa89 germa89 merged commit ea62b81 into main Nov 26, 2025
40 checks passed
@germa89 germa89 deleted the fix/cicd branch November 26, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie clatapie is a code owner automatically assigned from ansys/pymapdl-maintainers

Assignees

@germa89 germa89

Labels

bug Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@germa89 @pyansys-ci-bot