Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 24, 2025

Description

As the title.

Issue linked

Close #4313

Checklist

Copilot AI review requested due to automatic review settings November 24, 2025 19:59
@germa89 germa89 requested a review from a team as a code owner November 24, 2025 19:59
@germa89
Copy link
Collaborator Author

germa89 commented Nov 24, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates pytest configuration by moving test arguments from workflow environment variables into the centralized pyproject.toml configuration file. This change improves maintainability by having a single source of truth for pytest settings and simplifies the CI/CD workflow definitions.

Key Changes

  • Expanded pytest arguments in pyproject.toml from a single string to a detailed list with coverage, profiling, and logging options
  • Simplified workflow environment variables by removing redundant pytest arguments that are now defined in pyproject.toml
  • Cleaned up test execution commands in both local and remote workflows by removing duplicate argument specifications

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Expanded pytest configuration from single-line string to comprehensive multi-line list with coverage, profiling, and logging options
.github/workflows/test-remote.yml Simplified PYTEST_ARGUMENTS to only include workflow-specific --ignore_image_cache flag, removing arguments now in pyproject.toml
.github/workflows/test-local.yml Cleared PYTEST_ARGUMENTS environment variable, relying entirely on pyproject.toml configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc dependencies maintenance General maintenance of the repo (libraries, cicd, etc) bug Issue, problem or error in PyMAPDL labels Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.36%. Comparing base (8efc45e) to head (8a8a5fb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4322      +/-   ##
==========================================
+ Coverage   91.27%   91.36%   +0.09%     
==========================================
  Files         193      193              
  Lines       15742    15742              
==========================================
+ Hits        14368    14383      +15     
+ Misses       1374     1359      -15     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

germa89 and others added 3 commits November 26, 2025 15:37
@germa89 germa89 merged commit 0f28b4e into main Nov 26, 2025
127 of 129 checks passed
@germa89 germa89 deleted the fix/using-addopt-instead-of-env-vars-in-CI branch November 26, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc dependencies maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use addopt from the pyproject.toml

3 participants