-
Notifications
You must be signed in to change notification settings - Fork 140
fix(tests): update pytest arguments for consistency and clarity in local and remote workflows #4322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cal and remote workflows
|
@pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR consolidates pytest configuration by moving test arguments from workflow environment variables into the centralized pyproject.toml configuration file. This change improves maintainability by having a single source of truth for pytest settings and simplifies the CI/CD workflow definitions.
Key Changes
- Expanded pytest arguments in
pyproject.tomlfrom a single string to a detailed list with coverage, profiling, and logging options - Simplified workflow environment variables by removing redundant pytest arguments that are now defined in
pyproject.toml - Cleaned up test execution commands in both local and remote workflows by removing duplicate argument specifications
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Expanded pytest configuration from single-line string to comprehensive multi-line list with coverage, profiling, and logging options |
| .github/workflows/test-remote.yml | Simplified PYTEST_ARGUMENTS to only include workflow-specific --ignore_image_cache flag, removing arguments now in pyproject.toml |
| .github/workflows/test-local.yml | Cleared PYTEST_ARGUMENTS environment variable, relying entirely on pyproject.toml configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4322 +/- ##
==========================================
+ Coverage 91.27% 91.36% +0.09%
==========================================
Files 193 193
Lines 15742 15742
==========================================
+ Hits 14368 14383 +15
+ Misses 1374 1359 -15 🚀 New features to boost your workflow:
|
…pt-instead-of-env-vars-in-CI
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Description
As the title.
Issue linked
Close #4313
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)