Skip to content

Conversation

pmaroneh
Copy link
Contributor

@pmaroneh pmaroneh commented Mar 3, 2022

In this PR I am adding a new example of a dynamic simulation (modal and PSD analysis) of a printed circuit board.
This example is inspired from Chapter 20 of the Technology Showcase Example Problems Manual.

@pmaroneh pmaroneh requested a review from germa89 March 3, 2022 16:13
@pmaroneh pmaroneh self-assigned this Mar 3, 2022
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #938 (5842648) into main (d37086d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   73.02%   73.02%           
=======================================
  Files          39       39           
  Lines        5712     5712           
=======================================
  Hits         4171     4171           
  Misses       1541     1541           

@germa89
Copy link
Collaborator

germa89 commented Mar 3, 2022

Good!

germa89
germa89 previously requested changes Mar 3, 2022
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ask me later.

@pmaroneh
Copy link
Contributor Author

pmaroneh commented Mar 4, 2022

Codacity check fails because of these:
image
but this matches what is been done in the files (and also I still get an error if I resolve this, telling me that the docstring should start at the first line...)

@pmaroneh
Copy link
Contributor Author

pmaroneh commented Mar 8, 2022

Only remaining unsuccessful check is:
image
Which, as far as I know, I did not modify...

@pmaroneh pmaroneh marked this pull request as ready for review March 8, 2022 15:17
@akaszynski
Copy link
Collaborator

I'm fixing the codacy requirements. Minor shouldn't be enforced.

BTW, it's not required for merge, but it is annoying to see those red x's.

@akaszynski
Copy link
Collaborator

@pmaroneh, please see the changes made here to make the example more readable:
0ec1211

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work all! This is good to merge, example looks great and reads well.

@germa89 germa89 self-requested a review March 9, 2022 18:10
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice example @pmaroneh ! Looks great!

Welcome to the team!! :D

@akaszynski akaszynski dismissed germa89’s stale review March 9, 2022 18:16

Changes made

@pmaroneh pmaroneh merged commit 5c73c06 into main Mar 10, 2022
@pmaroneh pmaroneh deleted the doc/dynamic_simulation_pcb branch March 10, 2022 08:34
@germa89 germa89 restored the doc/dynamic_simulation_pcb branch March 10, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants