Remove previous temporal files. #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #943 +/- ##
==========================================
+ Coverage 72.79% 72.82% +0.03%
==========================================
Files 39 39
Lines 5675 5675
==========================================
+ Hits 4131 4133 +2
+ Misses 1544 1542 -2 |
|
There will be a minor slow down to delete files, but if this improves stability, please merge. |
akaszynski
approved these changes
Mar 9, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mapdl.non_interactivecontext redirect the output to a file which is not deleted and it is always named the same.Some commands or pymapdl functions (for example
_get_array_parameter) use this file to do their job, but they need this file to have only that output.Hence, to avoid issues, PyMAPDL will delete the files after reading them.