Removing temp files in Math testing. #973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #973 +/- ##
=======================================
Coverage 73.09% 73.09%
=======================================
Files 39 39
Lines 5720 5720
=======================================
Hits 4181 4181
Misses 1539 1539 |
|
Ideally these files wouldn’t have been created in the local directory in the first place. Can we use a temp directory instead? If not, feel free to merge. |
akaszynski
approved these changes
Mar 15, 2022
|
In some cases, I need to test a path without directories, but I agree that most of the cases, a tmp dir is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #969 by removing extra files at the end of the testing.