Using a newer version of pymapdl reader.

[germa89]

Not forcing any particular version, just lower bound.

This close #979 by updating pymapdl reader version.

[germa89]

Using 0.51.6 because it is when the deprecation warnings were fixed.

[codecov]

Codecov Report

Merging #980 (158d682) into main (247c55d) will increase coverage by 0.19%.
The diff coverage is n/a.

❗ Current head 158d682 differs from pull request most recent head 616cea2. Consider uploading reports for the commit 616cea2 to get more accurate results

@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
+ Coverage   73.08%   73.28%   +0.19%     
==========================================
  Files          39       39              
  Lines        5719     5750      +31     
==========================================
+ Hits         4180     4214      +34     
+ Misses       1539     1536       -3     

[akaszynski]

I recall that our doc build fails when using the latest. Try modifying the version just to test. Something like …dev1

[germa89]

Interestingly...

the nightly docs build fails with this branch: https://github.com/pyansys/pymapdl/runs/5585437476?check_suite_focus=true

however the github actions workflow seems to work: https://github.com/pyansys/pymapdl/actions/runs/1998389547/attempts/1
I'm double checking this by re-running this again.

-- Edit --
The second try works too.
https://github.com/pyansys/pymapdl/actions/runs/1998389547

[germa89]

For reference

I have been doing a bit of investigation in the example 04-rotational-displacement.py, which is where it crashes.

It fails in the line 77 when calling result.plot_principal_nodal_stress(...).
The traceback is:

plot_principal_nodal_stress() > principal_nodal_stress > nodal_stress > _nodal_results > _binary_reader.read_nodal_values.

The traceback goes now to the pyx file _binary_reader.pyx.

In the function read_nodal_values, it does some iterations (24 to be more precise). And then it goes to line 952 (function read_element) https://github.com/pyansys/pymapdl-reader/blob/cbda77080e04836c82c40f99fd6c9c10da57ff03/ansys/mapdl/reader/cython/_binary_reader.pyx#L952

and it fails there (it seems) in the last iteration, at the line:
https://github.com/pyansys/pymapdl-reader/blob/cbda77080e04836c82c40f99fd6c9c10da57ff03/ansys/mapdl/reader/cython/_binary_reader.pyx#L1158

I believe the issue is with bufferdata or data.

[akaszynski]

Looks like I’m reading past the end of an array. Keep this PR alive; it will remind me to fix the reader.

[akaszynski]

@germa89, looks like it's fixed in ansys-mapdl-reader. I'm going to still pin it just so we're sure it's why our docs are failing.

[akaszynski]

LGTM

[akaszynski]

@germa89, looks like a full doc rebuild works as well.

[germa89]

Thank you @akaszynski for this fix.