Skip to content

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 16, 2022

Another try...

@germa89 germa89 self-assigned this Mar 16, 2022
@germa89 germa89 added the BUG label Mar 16, 2022
@germa89 germa89 marked this pull request as draft March 16, 2022 17:38
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #982 (1785e12) into main (0126ad9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #982   +/-   ##
=======================================
  Coverage   73.15%   73.15%           
=======================================
  Files          39       39           
  Lines        5730     5730           
=======================================
  Hits         4192     4192           
  Misses       1538     1538           

@germa89 germa89 added the DO NOT MERGE Not ready to be merged yet label Mar 17, 2022
@germa89
Copy link
Collaborator Author

germa89 commented Mar 17, 2022

Finally!

https://dev.mapdldocs.pyansys.com/api/indkkex.html

image

I checked this running the nightly build workflow in this branch, and it seems to generate right template.

Another point of discussion is if this is the right page. Ansys 404 is:

image

I feel we should do something like a picture of a non-converging plot or something... right now it is too simple.

@germa89
Copy link
Collaborator Author

germa89 commented Mar 17, 2022

@germa89 germa89 marked this pull request as ready for review March 17, 2022 10:03
@germa89 germa89 removed the DO NOT MERGE Not ready to be merged yet label Mar 17, 2022
@akaszynski
Copy link
Collaborator

Ask the lsdyna guys for some tearing or crashing gif. We can use that

@akaszynski akaszynski merged commit 2d5d3d2 into main Mar 17, 2022
@akaszynski akaszynski deleted the fix/page404-format branch March 17, 2022 17:13
@germa89
Copy link
Collaborator Author

germa89 commented Mar 28, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants