Skip to content

Fix build documentation step #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

Fix build documentation step #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/ci_cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ jobs:

docs_build:
name: Build Documentation
runs-on: [self-hosted, Linux, pyrocky]
runs-on: [self-hosted, Windows, pyrocky]
if: |
contains(github.event.pull_request.labels.*.name, 'docs') ||
github.ref == 'refs/heads/main'
Expand All @@ -208,17 +208,17 @@ jobs:

- name: Create Python venv
run: |
python -m venv .venv-docs
python -m venv .venv

- name: Install packages for documentation build
run: |
source .venv-docs/bin/activate
.\.venv\Scripts\Activate.bat
pip install .[doc]

- name: Build Source Documentation (HTML)
run: |
source .venv-docs/bin/activate
make -C doc/ html --quiet
.\.venv\Scripts\Activate.bat
doc\make.bat html

- name: Upload HTML Documentation
uses: actions/upload-artifact@v4
Expand All @@ -229,8 +229,8 @@ jobs:

- name: Build Source Documentation (PDF)
run: |
source .venv-docs/bin/activate
make -C doc/ pdf --quiet
.\.venv\Scripts\Activate.bat
doc\make.bat pdf

- name: Upload PDF documentation
uses: actions/upload-artifact@v4
Expand Down
4 changes: 2 additions & 2 deletions src/ansys/rocky/core/launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def launch_rocky(
if rocky_exe is None or not rocky_exe.is_file():
raise FileNotFoundError(f"Rocky executable is not found.")

cmd = [rocky_exe, "--pyrocky", "--pyrocky-port", str(server_port)]
cmd = [str(rocky_exe), "--pyrocky", "--pyrocky-port", str(server_port)]
if headless:
cmd.append("--headless")
with contextlib.suppress(subprocess.TimeoutExpired):
Expand Down Expand Up @@ -180,7 +180,7 @@ def launch_freeflow( # pragma: no cover
if freeflow_exe is None or not freeflow_exe.is_file():
raise FileNotFoundError(f"Freeflow executable is not found.")

cmd = [freeflow_exe, "--pyrocky", "--pyrocky-port", str(server_port)]
cmd = [str(freeflow_exe), "--pyrocky", "--pyrocky-port", str(server_port)]
if headless:
cmd.append("--headless")
with contextlib.suppress(subprocess.TimeoutExpired):
Expand Down
Loading