Skip to content

Conversation

@anskpetsche
Copy link
Collaborator

Description

Added function get_test_point_props() in Layer class, added new layer type GetTestPointPropertiesRequest and added new unit tests to test_layer.py

Issue linked

#578

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@anskpetsche anskpetsche linked an issue Jun 11, 2025 that may be closed by this pull request
@github-actions github-actions bot added testing Anything related to tests documentation Improvements or additions to documentation labels Jun 11, 2025
@ansjmoody ansjmoody added this to the 2026 R1 milestone Jun 13, 2025
@ansjmoody ansjmoody added enhancement New features or code improvements and removed documentation Improvements or additions to documentation testing Anything related to tests labels Jun 13, 2025
@github-actions github-actions bot added testing Anything related to tests documentation Improvements or additions to documentation labels Jun 13, 2025
@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related labels Jun 13, 2025
@anskpetsche anskpetsche changed the title FEAT: Added API GetTestPointProperties feat: Added API GetTestPointProperties Jun 13, 2025
@ansjmoody ansjmoody removed dependencies Related with project dependencies maintenance Package and maintenance related labels Jun 13, 2025
@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related labels Jun 13, 2025
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 64.51613% with 11 lines in your changes missing coverage. Please review.

Project coverage is 60.89%. Comparing base (0094744) to head (9893a08).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/sherlock/core/types/layer_types.py 75.00% 6 Missing ⚠️
src/ansys/sherlock/core/layer.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   60.88%   60.89%           
=======================================
  Files          21       21           
  Lines        5487     5516   +29     
=======================================
+ Hits         3341     3359   +18     
- Misses       2146     2157   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anskpetsche anskpetsche enabled auto-merge (squash) June 16, 2025 19:56
auto-merge was automatically disabled June 17, 2025 12:56

Pull request was closed

@anskpetsche anskpetsche reopened this Jun 17, 2025
@anskpetsche anskpetsche enabled auto-merge (squash) June 17, 2025 13:25
@anskpetsche anskpetsche merged commit a4afa54 into main Jun 17, 2025
25 checks passed
@anskpetsche anskpetsche deleted the kristine/test_point_properties_API branch June 17, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add API: get_test_point_properties()

4 participants