Skip to content

Conversation

@ansys-pwalters
Copy link
Collaborator

Description

Added import thermal signal API

Issue linked

606

Checklist:

  • [y] Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • [y] Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • [y] Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • [y] Generate documentation
  • [y] Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • [] Check that test code coverage is at least 80% when Sherlock is running
  • [y] Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@github-actions github-actions bot added testing Anything related to tests documentation Improvements or additions to documentation labels Jul 25, 2025
@ansjmoody ansjmoody enabled auto-merge (squash) July 25, 2025 18:34
@ansjmoody ansjmoody added the enhancement New features or code improvements label Jul 30, 2025
@ansjmoody ansjmoody added this to the 2026 R1 milestone Jul 30, 2025
@ansjmoody ansjmoody linked an issue Jul 30, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 90.41096% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.36%. Comparing base (22c7680) to head (740f461).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/sherlock/core/lifecycle.py 55.55% 4 Missing ⚠️
src/ansys/sherlock/core/types/lifecycle_types.py 95.31% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
+ Coverage   61.00%   61.36%   +0.35%     
==========================================
  Files          21       22       +1     
  Lines        5627     5700      +73     
==========================================
+ Hits         3433     3498      +65     
- Misses       2194     2202       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ansjmoody ansjmoody merged commit 74d5a8e into main Jul 30, 2025
27 checks passed
@ansjmoody ansjmoody deleted the pwalters/thermalSignal branch July 30, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ... New API to import thermal signal

4 participants